Skip to content

[NOT AZURE] Updated Azure Stack Infrastructure Insights Admin SDK#4252

Merged
dsgouda merged 2 commits intoAzure:psSdkJson6from
deathly809:InfrastructureInsightsAdmin
Apr 23, 2018
Merged

[NOT AZURE] Updated Azure Stack Infrastructure Insights Admin SDK#4252
dsgouda merged 2 commits intoAzure:psSdkJson6from
deathly809:InfrastructureInsightsAdmin

Conversation

@deathly809
Copy link
Copy Markdown
Member

@deathly809 deathly809 commented Apr 20, 2018

Description

Recreated the FRP specifications and regenerated the SDK.

Azure/azure-rest-api-specs#2812

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

dsgouda
dsgouda suggested changes Apr 20, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a version bump

Comment thread ...astructureInsights.Admin/Microsoft.AzureStack.Management.InfrastructureInsights.Admin.csproj
<TargetFrameworks>net452;netstandard1.4</TargetFrameworks>
</PropertyGroup>
<PropertyGroup>
<PackageId>Microsoft.AzureStack.Management.InfrastructureInsights.Admin</PackageId>
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Apr 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this package is already published and there are some additive changes being introduced. Please update the package version number

@deathly809
Copy link
Copy Markdown
Member Author

deathly809 commented Apr 21, 2018

@dsgouda Done! Also, do we publish the Nugets? We might have to update the package release notes.

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Apr 23, 2018 •
edited
Loading

@deathly809 I believe so, please check here

@deathly809
Copy link
Copy Markdown
Member Author

deathly809 commented Apr 23, 2018

@dsgouda I already updated the version. So I have to kick off the build process correct? Just to be 100% clear.

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Apr 23, 2018

By build if you mean publish the package, then yes. The "build" itself was done successfully here by the CI machines.
What you may have to consider is updating the PackageReleaseNotes, let me know if you plan to do so

@deathly809
Copy link
Copy Markdown
Member Author

deathly809 commented Apr 23, 2018

@dsgouda I have been trying to get feedback on that. We might just have a single PR to update all the admin PackageReleaseNotes and then kick of a publish job.

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Apr 23, 2018

That would be a good idea. Will merge this for now, feel free to open a new PR for the release notes.

dsgouda
dsgouda approved these changes Apr 23, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 30df261 into Azure:psSdkJson6 Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deathly809 @dsgouda